Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node from 16 to 17 #3665

Closed
wants to merge 1 commit into from
Closed

Conversation

thomasetter
Copy link
Contributor

@thomasetter thomasetter commented Oct 23, 2023

This seems to be the last version which "just works" by bumping the version number.

18 fails with

     Running `target/debug/wasm-bindgen-test-runner /home/runner/work/wasm-bindgen/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/wasm-3858e35c736746aa.wasm`
                                                  
Set timeout to 20 seconds...
Executing bindgen...                              
node: bad option: --experimental-wasm-reftypes
error: test failed, to rerun pass `--test wasm`

Caused by:
  process didn't exit successfully: `cargo run -p wasm-bindgen-cli --bin wasm-bindgen-test-runner -- /home/runner/work/wasm-bindgen/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/wasm-3858e35c736746aa.wasm` (exit status: 9)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
                                                  
Error: Process completed with exit code 9.

https://github.com/thomasetter/wasm-bindgen/actions/runs/6611564031/job/17955697825?pr=4

Copy link
Collaborator

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not use a non-lts version of nodejs

@thomasetter
Copy link
Contributor Author

Sounds good, #3666 brings it to 20, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants