Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the node version in the GitHub workflows from 16 to 20 #3666

Merged
merged 1 commit into from
Oct 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -82,7 +82,7 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- uses: ./.github/actions/setup-geckodriver
- run: cargo test --target wasm32-unknown-unknown
- run: cargo test --target wasm32-unknown-unknown --features serde-serialize
@@ -101,7 +101,6 @@ jobs:
- run: cargo test --target wasm32-unknown-unknown
env:
WASM_BINDGEN_EXTERNREF: 1
NODE_ARGS: --experimental-wasm-reftypes
- run: cargo test --target wasm32-unknown-unknown
env:
WASM_BINDGEN_MULTI_VALUE: 1
@@ -130,7 +129,7 @@ jobs:
# - run: rustup target add wasm32-unknown-unknown
# - uses: actions/setup-node@v3
# with:
# node-version: '16'
# node-version: '20'
# - uses: ./.github/actions/setup-geckodriver
# - run: cargo test --target wasm32-unknown-unknown
# env:
@@ -151,7 +150,7 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- run: cargo test
- run: cargo test -p wasm-bindgen-cli-support
- run: cargo test -p wasm-bindgen-cli
@@ -171,7 +170,7 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- uses: ./.github/actions/setup-geckodriver
- run: cargo build --manifest-path crates/web-sys/Cargo.toml --target wasm32-unknown-unknown
- run: cargo build --manifest-path crates/web-sys/Cargo.toml --target wasm32-unknown-unknown --features Node
@@ -200,7 +199,7 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- uses: ./.github/actions/setup-geckodriver
- run: cargo test -p js-sys --target wasm32-unknown-unknown
- run: cargo test -p js-sys --target wasm32-unknown-unknown
@@ -216,7 +215,7 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- run: cargo test -p wasm-bindgen-webidl
- run: cargo test -p webidl-tests --target wasm32-unknown-unknown
env:
@@ -234,7 +233,7 @@ jobs:
- run: rustup target add wasm32-unknown-unknown
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
- run: cd crates/typescript-tests && ./run.sh

test_deno: