Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #3676

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Bump versions #3676

merged 3 commits into from
Nov 1, 2023

Conversation

ranile
Copy link
Collaborator

@ranile ranile commented Oct 31, 2023

This PR should be created automatically but I don't permissions to allow GitHub actions to do that. Right now, it fails with:

pull request create failed: GraphQL: Resource not accessible by integration (createPullRequest)

See logs

@alexcrichton can you allow actions to create PRs.
Please also publish this release

Fixes: #3530

@alexcrichton
Copy link
Contributor

Oh I think that checkbox is already checked?

Also are you interested in automating the release more? If that's the case I think that's great! I can publish in the meantime, but I'm also happy to put a token on this repo's secrets to get published from workflows here.

@ranile
Copy link
Collaborator Author

ranile commented Oct 31, 2023

@alexcrichton yes, please do add the secret. I would also like to reduce it down to one step, so adding a secret is necessary. You can go ahead and publish this release. We can automate the next one

@alexcrichton
Copy link
Contributor

Ok! I've added CRATES_PUBLISH_TOKEN as a crate secret here. It's scoped to wasm-bindgen*, js-sys, and web-sys only, but I think that should work?

Otherwise I'll defer to y'all when to merge this, but when merged I'll tag this and publish it.

@Liamolucko
Copy link
Collaborator

There's one more version that still needs to be bumped, which is the 'Unreleased' heading in CHANGELOG.md that should now become 0.2.88. That should be it though, looking at #3475 for a reference.

@ranile
Copy link
Collaborator Author

ranile commented Oct 31, 2023

I bumped it manually this time but we should update the script to automate this

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Liam Murphy <liampm32@gmail.com>
@ranile
Copy link
Collaborator Author

ranile commented Nov 1, 2023

I'm going to merge this for @alexcrichton to publish and tag. We can use the automated workflow from next release (I would love to fix it now but unfortunately I got ill...)

@ranile ranile merged commit 0b5f0ee into main Nov 1, 2023
25 checks passed
@ranile ranile deleted the bump branch November 1, 2023 15:35
@alexcrichton
Copy link
Contributor

Ok published and tagged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to release a new version of web-sys
5 participants