Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Tiny PR) Show JsValue is not Send/Sync explicitly #3735

Closed
wants to merge 1 commit into from

Conversation

fzyzcjy
Copy link

@fzyzcjy fzyzcjy commented Dec 6, 2023

Hi thanks for the library! I was confused why JsValue is not Send/Sync, and after searching I see #955. Therefore, I make this tiny PR to add doc telling users why this is the case.

@fzyzcjy fzyzcjy changed the title Show JsValue is not Send/Sync explicitly (Tiny PR) Show JsValue is not Send/Sync explicitly Dec 6, 2023
@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 6, 2023

Hmm OK, Rust is not stablized yet for that grammar...

@fzyzcjy fzyzcjy closed this Dec 6, 2023
@daxpedda
Copy link
Collaborator

daxpedda commented Dec 7, 2023

Just for reference: this should already be visible, even if not that notable.
image

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 7, 2023

@daxpedda Thank you. Yes I know, I just want to paste those comments there, otherwise I was wondering why it is not Send/Sync

@daxpedda
Copy link
Collaborator

daxpedda commented Dec 8, 2023

That's a limitation by JS, which requires any value to be send to another web worker via postMessage(), therefor they can't be Send/Sync.

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 8, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants