Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unstable bindings for the FileSystemAccess API (#3799) #3810

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add unstable bindings for the FileSystemAccess API (#3799) #3810

merged 5 commits into from
Jan 24, 2024

Conversation

maurerdietmar
Copy link
Contributor

No description provided.

daxpedda
daxpedda requested changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the changelog as well.

crates/web-sys/webidls/unstable/FileSystemAccess.webidl Outdated Show resolved Hide resolved
daxpedda
daxpedda approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Needs a rebase though.

@daxpedda daxpedda merged commit c4f81f5 into rustwasm:main Jan 24, 2024
25 checks passed
@maurerdietmar maurerdietmar deleted the add-file-system-access branch January 24, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurerdietmar @daxpedda