Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RtcPeerConnectionIceErrorEvent WebAPI #3835

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Add RtcPeerConnectionIceErrorEvent WebAPI #3835

merged 3 commits into from
Feb 8, 2024

Conversation

evdokimovs
Copy link
Contributor

This pull request introduces support for the RtcPeerConnectionIceErrorEvent WebAPI. Here is spec for this type: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnectioniceerrorevent

daxpedda
daxpedda requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a changelog entry but otherwise LGTM!

@evdokimovs
Copy link
Contributor Author

@daxpedda

Missing a changelog entry but otherwise LGTM!

Sorry, forgot about it. Added changelog entry.

@evdokimovs evdokimovs requested a review from daxpedda February 8, 2024 11:24
daxpedda
daxpedda approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@daxpedda daxpedda merged commit e9cb333 into rustwasm:main Feb 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evdokimovs @daxpedda