Annotate methods in WebCodecs that throw #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pablosichert this needs a rebase, I was about to do it myself but I don't have permissions because the repo is in an organization. |
pablosichert
force-pushed
the
webcodecs-throws
branch
from
7977861
to
41a554a
Compare
|
@daxpedda thank you for reviewing – just rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through all methods in
WebCodecs.webidland annotated those that throw according to the spec with[Throws].This is not a breaking change since the
WebCodecs.webidlfile is located in theunstabledirectory.