Deprecate JsStatic
in favor of #[wasm_bindgen(thread_local)]
#4057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecated
JsStatic
in favor of#[wasm_bindgen(thread_local)]
, which creates astd::thread::LocalKey
. The syntax is otherwise the same.JsStatic
was pretty much a hack that exposed a thread local variable by transmuting the lifetime to'static
, which does make sense on Web, but not with multi-threading, which was making this rather unsound.Additionally,
impl Deref for JsStatic
is not present anymore when compiling withcfg(target_feature = "atomics")
to remove the possibility of unsoundness entirely.