Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative BigInt formatting #4082

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix negative BigInt formatting #4082

merged 4 commits into from
Aug 21, 2024

Conversation

ryangoree
Copy link
Contributor

Closes: #4081

daxpedda
daxpedda requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an entry in the changelog.
Thank you!

crates/js-sys/src/lib.rs Outdated Show resolved Hide resolved
@ryangoree
Copy link
Contributor Author

This needs an entry in the changelog. Thank you!

I added an entry to the top-level changelog which seemed to be the convention, but lmk otherwise.

daxpedda
daxpedda approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

crates/js-sys/src/lib.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda merged commit 0cbca31 into rustwasm:main Aug 21, 2024
This was referenced Aug 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sign is printed twice when formatting a negative BigInt
2 participants
@ryangoree @daxpedda