Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js_sys: Add #[derive(Clone, Debug)] to Promise #957

Merged
merged 1 commit into from
Oct 10, 2018
Merged

js_sys: Add #[derive(Clone, Debug)] to Promise #957

merged 1 commit into from
Oct 10, 2018

Conversation

alexcrichton
Copy link
Contributor

I think we just forgot this from earlier!

@alexcrichton
js_sys: Add #[derive(Clone, Debug)] to Promise
e9fa209 
I think we just forgot this from earlier!
@alexcrichton
Copy link
Contributor Author

FWIW I also did a quick audit and the only ones still missing this are JSON and Math, neither of which have instances to work with anyway.

fitzgen
fitzgen approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for auditing!

@alexcrichton alexcrichton merged commit e0b73ab into rustwasm:master Oct 10, 2018
@alexcrichton alexcrichton deleted the promise-clone branch October 11, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @fitzgen