Bind more Typed Array constructors in js-sys
#970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bind `new Int8Array(length)`, `new Int8Array(buffer, offset)` and `new Int8Array(buffer, offset, length)`.
alexcrichton
force-pushed
the
more-new
branch
from
9b581c5 to
9effb7c
Compare
sendilkumarn
approved these changes
Oct 16, 2018
|
We can certainly consider that yeah! I think the documentation may be harder but we could probably figure out a way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind
new Int8Array(length),new Int8Array(buffer, offset)andnew Int8Array(buffer, offset, length).