Skip to content

Commit

Permalink
Merge pull request #484 from csmoe/valid
Browse files Browse the repository at this point in the history
validate target argument
  • Loading branch information
ashleygwilliams authored Jan 11, 2019
2 parents 35cabb6 + 065a28f commit 4cd7790
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/command/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ pub struct BuildOptions {
pub scope: Option<String>,

#[structopt(long = "mode", short = "m", default_value = "normal")]
/// Sets steps to be run. [possible values: no-install, normal]
/// Sets steps to be run. [possible values: no-install, normal, force]
pub mode: BuildMode,

#[structopt(long = "no-typescript")]
Expand Down Expand Up @@ -158,6 +158,12 @@ impl Build {
_ => bail!("Can only supply one of the --dev, --release, or --profiling flags"),
};

// `possible_values` in clap isn't supported by `structopt`
let possible_targets = ["browser", "nodejs", "no-modules"];
if !possible_targets.contains(&build_opts.target.as_str()) {
bail!("Supported targets: browser, nodejs, no-modules");
}

Ok(Build {
crate_path,
crate_data,
Expand Down

0 comments on commit 4cd7790

Please sign in to comment.