pack error on Windows 10 17746

[wangzishi]

🐛 Bug description

I just try the hello world on my computer.
Project structure is

wasm-pack init is success

but wasm-pack pack . is faild

wasm-pack.log

Aug 31 10:21:31.981 INFO Running pack command...
Aug 31 10:21:31.982 INFO Path: Some(".")
Aug 31 10:21:31.982 INFO Packing up the npm package...
Aug 31 10:21:31.982 ERRO 系统找不到指定的文件。 (os error 2)

🤔 Expected Behavior

No error occurred

👟 Steps to reproduce

1. create new hello world project
2. wasm-pack init
3. wasm-pack pack .

🌍 Your environment

os: windows 10 x64 17746.1000
wasm-pack version: 0.4.2
rustc version: 1.30.0-nightly (02cb8f2a4 2018-08-29)

[fitzgen]

Thanks for the bug report!

[csmoe]

@wangzishi I suspect that npm wasn't installed on your machine, could you paste the npm meta info here?

---

@fitzgen
anyway, pack cmd invokes npm directly

wasm-pack/src/npm.rs

Lines 10 to 18 in 89be40d

	pub fn npm_pack(path: &str) -> Result<(), Error> {
	let output = Command::new("npm").current_dir(path).arg("pack").output()?;
	if !output.status.success() {
	let s = String::from_utf8_lossy(&output.stderr);
	Error::cli("Packaging up your code failed", s)
	} else {
	Ok(())
	}
	}

maybe better to add a binary exsit_or_not checking as you did in test PR here?

[fitzgen]

That sounds good to me! We should probably always do that, just to get good error messages to users

[wangzishi]

@csmoe I do have npm and node installed on my machine.

[ashleygwilliams]

ah @wangzishi what happens when you run wasm-pack pack (without the dot?). the dot shouldn't cause an issue but it may be...

[wangzishi]

@ashleygwilliams
and it has the same output.

what else can I help?

[ashleygwilliams]

hrm. thanks so much for the response and sorry this is taking so long to figure out. @steveklabnik do you think you could try this locally?

[steveklabnik]

I get

C:\Users\steve> wasm-pack pack

| 🎒  packed up your package!

[csmoe]

this bug can be reproduced with Chinese-ver Windows7 in my virtualbox, comparing to stevelabnik's comment, I suspect that system locale is the one to be blamed.

[luotaoyeah]

this might help: rust-lang/rust#42791

[danwilhelm]

Unfortunately, this issue affects login, pack, and publish on Windows!

I verified that the cause suggested by @luotaoyeah is indeed occurring. Command places "npm" in quotes when calling it, which causes it to fail in Windows only.

The recommended solution is to call npm using cmd /c. I am working on a PR for this and have verified the cmd /c solution works. Unfortunately, it requires some OS-specific code -- but it seems unavoidable.

[ashleygwilliams]

@danwilhelm are you on discord or IRC? feel free to reach out to me on either platfrom (i'm ag_dubs)

[ashleygwilliams]

closed by #489! about to go out!

[danwilhelm]

@wangzishi @csmoe I was not able to test my commit on Chinese-ver Windows! Could you possibly verify whether it is fixed in wasm-pack 0.6.0?

[csmoe]

@danwilhelm thanks for the fix. I'll test then(my locale gussing maybe almost not the cause).