Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'pkg/.gitignore' in deno target #909

Open
juzi5201314 opened this issue Aug 28, 2020 · 2 comments · May be fixed by #1408
Open

'pkg/.gitignore' in deno target #909

juzi5201314 opened this issue Aug 28, 2020 · 2 comments · May be fixed by #1408
Labels
feature request needs discussion question Further information is requested

Comments

@juzi5201314
Copy link

In Deno, packages are usually hosted on github or other git hosting platforms.
But now the content of generated pkg/.gitignore is *, which will prevent pkg from being submitted to git.
Should the * in the .gitignore of the Deno target be deleted?
juzi5201314 added a commit to juzi5201314/wasm-pack that referenced this issue Aug 28, 2020
@juzi5201314
Delete * in .gitignore of Deno target rustwasm#909
c0cc625
@OliverBrotchie
Copy link

OliverBrotchie commented Aug 30, 2020 •
edited
Loading

Removing it gives the user more options; if they want to submit it via git, they can, if they don't, they can add /pkg to an external gitignore.

@webmaster128
Copy link

I think this is a problem on all targets

@mrothNET mrothNET linked a pull request Jul 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request needs discussion question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't create .gitignore in pkg directory mrothNET/wasm-pack
4 participants
@ashleygwilliams @webmaster128 @OliverBrotchie @juzi5201314