Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix files behavior on node, and generally remove redundancy in the files key #205

Merged
merged 9 commits into from
Jul 13, 2018

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jul 13, 2018

fixes #199 (FOR REAL THIS TIME)

this PR does several things:

  • passes the value of the target flag to the write_package_json method
  • optionally includes a _bg.js file in the files key if the target is nodejs
  • updates files key to NOT include the file in main (it is unecessary)
  • adds a test to ensure correct behavior on node
  • cleans up tests to test for correct files key

@ashleygwilliams ashleygwilliams added this to the 0.4.1 milestone Jul 13, 2018
@ashleygwilliams ashleygwilliams changed the title Mciantyre master fix files behavior on node, and generally remove redundancy in the files key Jul 13, 2018
@ashleygwilliams ashleygwilliams merged commit 87b62aa into master Jul 13, 2018
@ashleygwilliams ashleygwilliams deleted the mciantyre-master branch July 13, 2018 20:40
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

files.push(js_bg_file.to_string());
}
None => {}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I think this would be nicer as

if let Some(ref f) = js_bg_file {
    files.push(f.to_string());
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing wasm-bindgen file in package.json
3 participants