Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny missing documentation #208

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Deny missing documentation #208

merged 1 commit into from
Jul 13, 2018

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jul 13, 2018

And add all the missing doc comments.

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@fitzgen
Deny missing documentation
805b796 
And add all the missing doc comments.
@ashleygwilliams ashleygwilliams added this to the 0.4.1 milestone Jul 13, 2018
ashleygwilliams
ashleygwilliams approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're a hero 🥇

@ashleygwilliams ashleygwilliams merged commit 1f60d7f into rustwasm:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fitzgen @ashleygwilliams