Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for otp when publishing to npm #282

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

mstallmo
Copy link
Member

@mstallmo mstallmo commented Sep 6, 2018

closes #257

I added Stdio::inherit() for stdin and stdout tonpm_publish to get the CLI output from npm when a user tries to publish with otp enabled. This will allow the user to enter their otp and successfully publish their package to the registry.

Please let me know if there's any thing I need to tweak or fix!

Thanks!


Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed and have your
    cloned directory set to nightly
$ rustup override set nightly
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran rustfmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to test this out locally, but assuming i can get it work - we should be set. ideally i'd like to be able to test this with our test suite but i think that'd be difficult atm.

@ashleygwilliams ashleygwilliams added this to the 0.5.0 milestone Sep 11, 2018
@ashleygwilliams ashleygwilliams merged commit 2ef929d into rustwasm:master Sep 11, 2018
@mstallmo mstallmo deleted the add-otp-to-publish branch September 12, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm-pack publish does not support npm otp
2 participants