[WIP] feat(build): allow specifying multiple targets #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #157 / #469
There are still a few things that should be done:
A few things that would be great to get your feedback on @ashleygwilliams :
EsModulesPackage
, etc. and flattened that to theNpmPackage
, as I there was quite some duplication there, and I didn't see a good way to achieve the feature without that. I hope that's okay 😬 .{crate_name}.js
) should be used instead of the new names ({crate_name}_{target}.js
)? I guess that might be required for better compatibility?Make sure these boxes are checked! 📦✅
rustfmt
installedcargo fmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨