Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust webpack template tutorial #536

Merged
merged 6 commits into from
Feb 22, 2019

Conversation

DebugSteven
Copy link
Contributor

This is a work in progress PR for the rust webpack template tutorial.

At the moment, I believe the workflow to use the template is filled in pretty well. There are empty WIP files to talk more about the generated src/lib.rs file & the web-sys dependency in the Cargo.toml, in addition to the other dependencies & crate type that are discussed in the npm-browser-packages template tutorial.

I'd appreciate feedback on content so far & possibly what to do about duplication across tutorials, if that's a priority.

@ashleygwilliams ashleygwilliams changed the title rust webpack template tutorial [WIP] rust webpack template tutorial Jan 31, 2019
@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Jan 31, 2019
@ashleygwilliams ashleygwilliams added this to the 0.7.0 milestone Jan 31, 2019
@danwilhelm
Copy link
Member

If you'd like to save some time writing the deep dives, the Cargo.toml and lib.rs auto-generated by npm init rust-webpack are extremely similar to those described in the existing deep dives here: https://github.com/rustwasm/wasm-pack/tree/master/docs/src/tutorial/template-deep-dive

@DebugSteven
Copy link
Contributor Author

Hey @xtuc this PR is ready for review. I'm happy to make changes based on any feedback. Thanks for offering to look this over.

});
```

## Run The Project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed, Webpack's wasm-pack-plugin will spawn wasm-pack. Only npm start or npm run build in the root directory is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining that! I pushed up a change that I think reflects that a little better in the docs now.

@ashleygwilliams
Copy link
Member

@DebugSteven is this ready for review? Let me know! And thanks for all the effort! I'm excited for this to land :)

@DebugSteven
Copy link
Contributor Author

@ashleygwilliams It's ready for review! Thanks for your patience.

@ashleygwilliams ashleygwilliams modified the milestones: 0.8.0, 0.7.0 Feb 22, 2019
@ashleygwilliams ashleygwilliams changed the title [WIP] rust webpack template tutorial rust webpack template tutorial Feb 22, 2019
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll probably try to consolidate some of the duplication before the next release but this is really great!! thank you so much for all your efforts here!! <3

@ashleygwilliams ashleygwilliams merged commit d48f4d3 into rustwasm:marketing Feb 22, 2019
@DebugSteven DebugSteven deleted the marketing branch February 22, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants