Update prerequisites documentation #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
i think we should still link to the install Rust page in the README and the prereqs page (no need for it to be a whole page on it's own in the docs)- as many folks who come to wasm-pack are new to rust and would benefit from a CtA to install it.
otherwise i'm happy to merge this! thanks!
ashleygwilliams
added
changes requested
waiting on response
and removed
needs review
labels
A few assorted improvements to the prerequisites documentation: * Rust nightly/beta requirements are removed * Wording indicating that `wasm-pack` requires `npm` has been clarified * The dedicated Rust page was removed as it's largely just "install Rust" nowadays * The heading of the NPM page in the sidebar now includes `(optional)` to clarify that it's not required.
|
@ashleygwilliams hm I'm confused, this doesn't touch the README and there's still a link to the "install rust" page? |
|
ack! you are totally right, i read the prereq landing page too quickly. sorry about that. this is great! mergin! thank you! |
ashleygwilliams
added
changelog - docs
and removed
changes requested
waiting on response
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few assorted improvements to the prerequisites documentation:
wasm-packrequiresnpmhas been clarifiedRust" nowadays
(optional)to clarify that it's not required.