-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the docs #612
fix the docs #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I serve this locally and navigate to: http://localhost:3000/ it works at first glance, however if I navigate to: http://localhost:3000/prerequisites/index.html via the left side menu and then click on the here
link I get redirected to: http://localhost:3000/prerequisites/prerequisites/non-rustup-setups.html (the same behavior happens for the npm link) which is not what we want.
I also found a broken link in this file: https://raw.githubusercontent.com/rustwasm/wasm-pack/master/docs/src/prerequisites/npm.md the [Tutorial]: ../tutorial/index.html
should be [Tutorial]: ../tutorials/index.html
. Mind fixing that in this PR as well?
Found another broken link here in the bottom: https://raw.githubusercontent.com/rustwasm/wasm-pack/master/docs/src/tutorials/npm-browser-packages/getting-started/manual-setup.md Should also be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
docs/src/tutorials/npm-browser-packages/template-deep-dive/cargo-toml.md
Outdated
Show resolved
Hide resolved
docs/src/tutorials/npm-browser-packages/template-deep-dive/src-lib-rs.md
Outdated
Show resolved
Hide resolved
added some more stuff from the readme per @drager 's excellent suggestion. |
…go-toml.md Co-Authored-By: ashleygwilliams <ashley666ashley@gmail.com>
…-lib-rs.md Co-Authored-By: ashleygwilliams <ashley666ashley@gmail.com>
merging before CI because the relevant tests passed and i would like to get a release out. |
No description provided.