fix: Check for "rustup" rather than ".rustup" when checking for wasm32 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for wasm32 target we did check if the sysroot contained ".rustup". While this covered the most common cases it didn't work when using Docker. So checking for "rustup" instead covers both cases.
ashleygwilliams
approved these changes
Apr 2, 2019
|
@ashleygwilliams Yes, I think that would be a good idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for wasm32 target we did check if the sysroot contained ".rustup". While this covered the most common cases it didn't work when using Docker. So checking for "rustup" instead covers both
cases.
I also noticed another bug where if the target was found we printed the helpful information and not the way around so I fixed that as well. Also, the code linked to the wrong docs section since the last docs update so I corrected that.
This will fix #613