Corrected files included in package.json for bundler / no target (#837)

[lucashorward]

Make sure these boxes are checked! 📦✅

• You have the latest version of rustfmt installed

$ rustup component add rustfmt

• You ran cargo fmt on the code base before submitting
• You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Closes #837

wasm-pack build and wasm-pack build --target bundler generate a _bg.js file, but it is not added to the package.json. The file that is added, *.js will however reference the _bg.js, so when the package is distributed (both through pack or publish) it is not usable.

This change will fix that by passing the correct bool value to npm_data

As is the same for my other PR, there is some test failure that I locally also have on the master branch. Please let me know how to address this if possible

[Pauan]

Thanks! Just a couple small changes needed for this.

[Pauan]

This should be false. The to_commonjs method should also use false, only to_esmodules should be true.

[lucashorward]

But then there would be no change in behavior, and the issue as described would not be fixed? Please let me know if there is a better way of fixing this issue!

[Pauan]

This is the situation in the old code:

• to_commonjs -> true
• to_esmodules -> false
• to_web -> false
• to_nomodules -> false

This is the situation in your code:

• to_commonjs -> true
• to_esmodules -> true
• to_web -> false
• to_nomodules -> true

However it is supposed to be like this:

• to_commonjs -> false
• to_esmodules -> true
• to_web -> false
• to_nomodules -> false

It is only the bundler target (to_esmodules) which has the extra _bg.js file, the rest don't.

[lucashorward]

Thank you for the explanation - I have made the changes. However, I noticed in this and my previous pr that the test build_with_and_without_wasm_bindgen_debug keeps failing locally, and now I see that the same has happened on master. Originally I also had this issue on master locally so I thought it was a configuration issue on my side, but as it also fails in the CI I doubt that that is the case. Do you have any idea why this test fails?

[Pauan]

Yeah, I need to look into why that's failing, you can ignore that.

[Pauan]

Thanks!

[Kurble]

Is a release scheduled anytime soon in order to fix this issue?

[Corey600]

Is a release scheduled anytime soon in order to fix this issue?

+1

[lucashorward]

@ashleygwilliams

[igrep]

Same here. This bug prevents us from running even a simple example (e.g. https://developer.mozilla.org/en-US/docs/WebAssembly/Rust_to_wasm). So this patch should be released soon.

[lucashorward]

A workaround would be to reference this git repository directly in the cargo.toml:
wasm-pack = { git = "https://github.com/rustwasm/wasm-pack" }
But do note that that may include other unreleased changes that have been merged to master as well.

[igrep]

Let me add an easier workaround: adding the _bg.js file to the generated package.json manually.