Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand() -> torch::randint() #217

Merged
merged 5 commits into from
Apr 2, 2022
Merged

rand() -> torch::randint() #217

merged 5 commits into from
Apr 2, 2022

Conversation

ZenoTan
Copy link
Contributor

@ZenoTan ZenoTan commented Apr 1, 2022

Close #216

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #217 (4e3f983) into master (124bc09) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files          28       28           
  Lines        1120     1120           
=======================================
  Hits          810      810           
  Misses        310      310           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rusty1s rusty1s changed the title rand() -> torch::randint() rand() -> torch::randint() Apr 2, 2022
@rusty1s rusty1s added the enhancement New feature or request label Apr 2, 2022
Copy link
Owner

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot. Also added a test to confirm that torch.manual_seed works.

@rusty1s rusty1s merged commit 122811a into rusty1s:master Apr 2, 2022
@ZenoTan ZenoTan deleted the rand branch April 4, 2022 11:54
@ZenoTan ZenoTan mentioned this pull request Apr 7, 2022
RexYing pushed a commit to RexYing/pytorch_sparse that referenced this pull request Apr 26, 2022
* update

* update

* update

* update

* linting

* update

* test lr_scheduler

* fix adam

* update

* typo

* from_config

* typos

* use class-resolver

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neighbor Sampling: rand() <-> uniform distribution
3 participants