Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase compression for sensor image #2128

Closed
priyonto opened this issue Aug 24, 2024 · 8 comments
Closed

Increase compression for sensor image #2128

priyonto opened this issue Aug 24, 2024 · 8 comments
Labels
enhancement New feature or request
Milestone
2.11

Comments

@priyonto
Copy link
Collaborator

No description provided.

@priyonto priyonto added the enhancement New feature or request label Aug 24, 2024
@priyonto priyonto added this to the 2.11 milestone Aug 24, 2024
@priyonto priyonto self-assigned this Aug 24, 2024
priyonto added a commit that referenced this issue Aug 25, 2024
@priyonto
task: Make image compression level configurable from flags #2128
6615ea7 
Default value is: 40% compression down from 60%
priyonto added a commit that referenced this issue Aug 25, 2024
@priyonto
task: Make image compression level configurable from flags #2128 (#2129)
a79ced7 
Default value is: 40% compression down from 60%
@priyonto priyonto assigned markoaamunkajo and unassigned priyonto Aug 25, 2024
@markoaamunkajo
Copy link
Collaborator

Something fishy is going on with iOS jpg image conversion, discussing on the channel

Image

priyonto added a commit that referenced this issue Aug 28, 2024
@priyonto
fix: Fix image compression fraction #2128
51b9f8a
priyonto added a commit that referenced this issue Aug 28, 2024
@priyonto
fix: Fix image compression fraction #2128 (#2133)
2959d2c
@markoaamunkajo
Copy link
Collaborator

Works now, moving to done.

@markoaamunkajo markoaamunkajo removed their assignment Sep 2, 2024
@laurijamsa
Copy link
Member

laurijamsa commented Sep 2, 2024 •
edited
Loading

We need to compare image quality and find the highest compression setting that is producing good enough quality images and use that.

@laurijamsa laurijamsa reopened this Sep 2, 2024
@laurijamsa laurijamsa self-assigned this Sep 2, 2024
@laurijamsa
Copy link
Member

iOS still producing wrong resolution images for me. Longer side should be 3000px.

Image

@laurijamsa laurijamsa assigned priyonto and unassigned laurijamsa Sep 4, 2024
@markoaamunkajo
Copy link
Collaborator

@laurijamsa could you share same info of the original photo?

@laurijamsa
Copy link
Member

I used the same 200Mpix photo I shared you in the chat channel earlier

@laurijamsa
Copy link
Member

We need to compare image quality and find the highest compression setting that is producing good enough quality images and use that.

I checked with compression setting 0.2 and it looked already too much compressed. Let's go with 0.4 for now.

priyonto added a commit that referenced this issue Sep 4, 2024
@priyonto
fix: Use PHPicker API for sensor image selection #2128
698f38a
priyonto added a commit that referenced this issue Sep 4, 2024
@priyonto
fix: Use PHPicker API for sensor image selection #2128 (#2145)
4ffbf30
@priyonto priyonto removed their assignment Sep 4, 2024
@priyonto
Copy link
Collaborator Author

priyonto commented Sep 4, 2024

Fixed and Closing.

@priyonto priyonto closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.11
Development

No branches or pull requests
3 participants
@laurijamsa @priyonto @markoaamunkajo