Add project.yml for xcodegened project with SPM #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: migrate from development pods. What: created project.yml and refactored code to enable SPM based build. Steps: > brew install xcodegen > xcodegen > xed Ruuvi\ Station.xcodeproj/ Build and Run
|
SonarCloud Quality Gate failed.
|
priyonto
reviewed
Nov 12, 2023
| // The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "RuuviLocalization", | ||
| platforms: [.macOS(.v10_15), .iOS(.v13)], |
There was a problem hiding this comment.
We can probably set minimum target to iOS 14 since the main target is already bumped to iOS 14 min.
There was a problem hiding this comment.
I agree that main target is iOS 14+, but we don't need it in these packages :) Imho let's keep the iOS 13 for now, will bump it if there is a need
priyonto
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: migrate from development pods.
What: created project.yml and refactored code to enable SPM based build.
Steps: