Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload dSYM using recommended way (#1889) #1890

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Upload dSYM using recommended way (#1889) #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/firebase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,6 @@ jobs:
--groups ${{ secrets.ALPHA_TESTERS_GROUP }} \
--release-notes "${{ steps.build_changelog.outputs.changelog }}"

- name: Zip dSYM files
run: |
find ./Build/Station_Dev.xcarchive -name '*.dSYM' | xargs -I \{\} zip -r \{\}.zip \{\}

- name: Upload dSYM to Firebase
run: |
find ./Build/Station_Dev.xcarchive -name '*.dSYM.zip' | xargs -I \{\} ./.tools/firebase/firebase crashlytics:symbols:upload --app ${{ secrets.GOOGLE_APP_ID }} \{\}

- name: Clean up keychain and provisioning profiles
if: ${{ always() }}
run: |
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/testflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,6 @@ jobs:
echo -n "$EXPORT_PLIST" | base64 --decode > $EXPORT_PLIST_PATH
xcodebuild -exportArchive -archivePath ./Build/Station.xcarchive -exportOptionsPlist $EXPORT_PLIST_PATH -exportPath ${{ runner.temp }}/export

- name: Install firebase CLI
run: |
make installed_firebase

- name: Zip dSYM files
run: |
find ./Build/Station.xcarchive -name '*.dSYM' | xargs -I \{\} zip -r \{\}.zip \{\}

- name: Upload dSYM to Firebase
run: |
find ./Build/Station.xcarchive -name '*.dSYM.zip' | xargs -I \{\} ./.tools/firebase/firebase crashlytics:symbols:upload --app ${{ secrets.GOOGLE_APP_ID }} \{\}

- name: Upload to testflight
run: |
IPA_PATH=$RUNNER_TEMP/export/station.ipa
Expand Down
11 changes: 11 additions & 0 deletions Apps/RuuviStation/target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ targets:
CODE_SIGN_IDENTITY: "iPhone Distribution"
PROVISIONING_PROFILE_SPECIFIER: "match AdHoc com.ruuvi.station"
OTHER_LDFLAGS: -ld_classic
DEBUG_INFORMATION_FORMAT: "dwarf-with-dsym"
Debug:
CODE_SIGN_STYLE: Automatic
OTHER_LDFLAGS: -ld_classic
Expand All @@ -117,6 +118,16 @@ targets:
- $(SRCROOT)/Apps/RuuviStation/Sources/Resources/Plists/GoogleService-Info.plist
runOnlyWhenInstalling: true
basedOnDependencyAnalysis: false
- path: ../../scripts/build/upload_dsyms.sh
name: Upload dSYMs
inputFiles:
- ${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}
- ${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Resources/DWARF/${PRODUCT_NAME}
- ${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}/Contents/Info.plist
- $(TARGET_BUILD_DIR)/$(UNLOCALIZED_RESOURCES_FOLDER_PATH)/GoogleService-Info.plist
- $(TARGET_BUILD_DIR)/$(EXECUTABLE_PATH)
runOnlyWhenInstalling: true
basedOnDependencyAnalysis: false
schemes:
station:
build:
Expand Down
3 changes: 3 additions & 0 deletions scripts/build/upload_dsyms.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash

"${BUILD_DIR%/Build/*}/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/run"
Loading