Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Show unseen alert badge #1665 #1906

Merged
merged 2 commits into from
Jan 28, 2024
Merged

task: Show unseen alert badge #1665 #1906

merged 2 commits into from
Jan 28, 2024

Conversation

priyonto
Copy link
Collaborator

No description provided.

@@ -17,6 +17,8 @@ class NotificationService: UNNotificationServiceExtension {
}

private let notificationServiceAppGroup = UserDefaults(suiteName: "group.com.ruuvi.station.pnservice")
private let languageUDKey = "SettingsUserDegaults.languageUDKey"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for where this LoC?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit cleanup. It was earlier declared within a method below on the notification service.

@@ -109,7 +112,6 @@ extension NotificationService {
return ""
}

let languageUDKey = "SettingsUserDegaults.languageUDKey"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@priyonto priyonto merged commit fa5bf7d into dev Jan 28, 2024
2 checks passed
@priyonto priyonto deleted the task/1665 branch January 28, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants