Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plan tag to free mode sensor cards #392

Closed
markoaamunkajo opened this issue Feb 22, 2024 · 6 comments
Closed

Upgrade plan tag to free mode sensor cards #392

markoaamunkajo opened this issue Feb 22, 2024 · 6 comments
Labels
enhancement New feature or request ready to deploy

Comments

@markoaamunkajo
Copy link
Collaborator

markoaamunkajo commented Feb 22, 2024

Description:

"No history data. This sensor is in Free mode. Upgrade Plan"

Upgrade plan tag will be a link to open to cloud.ruuvi.com on sensor cards that have this tag.

Link URL:
English, other languages: cloud.ruuvi.com
Finnish: cloud.ruuvi.com/fi

Dashboard (image card, history card)
Image

Full card:
Image

@markoaamunkajo markoaamunkajo changed the title Upgrade now - links to free mode sensor cards Upgrade plan tag to free mode sensor cards Feb 23, 2024
@markoaamunkajo markoaamunkajo assigned io53 and unassigned laurijamsa and sini-maaria Feb 23, 2024
@markoaamunkajo markoaamunkajo added enhancement New feature or request and removed Spec Needed labels Feb 23, 2024
@sini-maaria
Copy link
Collaborator

Let's modify the string so that it doesn't have two sentences.

New:
"There is no historical data because this sensor is in Free mode."
"Tämä anturi on Free-tilassa, eikä historiatietoja ole saatavilla."

When the sensor is shared, show text but no Upgrade button. This is because the sharee cannot upgrade the plan, because he doesn't own it.

io53 pushed a commit that referenced this issue Apr 3, 2024
io53 pushed a commit that referenced this issue Apr 3, 2024
io53 pushed a commit that referenced this issue Apr 3, 2024
io53 pushed a commit that referenced this issue Apr 3, 2024
@io53 io53 assigned laurijamsa and unassigned io53 Apr 3, 2024
@laurijamsa
Copy link
Member

Alignment of the Update plan button in here does not seem quite correct. The Upgrade plan text looks also too big (or the button too small).

Image

@laurijamsa laurijamsa assigned io53 and unassigned laurijamsa Apr 4, 2024
io53 pushed a commit that referenced this issue Apr 10, 2024
@io53 io53 assigned markoaamunkajo and unassigned io53 Apr 10, 2024
@markoaamunkajo
Copy link
Collaborator Author

markoaamunkajo commented Apr 11, 2024

@io53 looks like this is also showing for not seen sensors, let's not show upgrade link when this banner is shown.

Image

@io53 io53 removed their assignment Apr 15, 2024
@markoaamunkajo
Copy link
Collaborator Author

@io53 now link is not shown on dashboard cards

Image

@markoaamunkajo
Copy link
Collaborator Author

Now shows on dashboard, will ask confirmation from @sini-maaria that this design is now good before marking as ready to deploy.

io53 pushed a commit that referenced this issue Apr 22, 2024
@markoaamunkajo
Copy link
Collaborator Author

Assuming this is done @io53

@markoaamunkajo markoaamunkajo added ready to deploy and removed bug Something isn't working labels Apr 23, 2024
@io53 io53 assigned markoaamunkajo and unassigned io53 Apr 30, 2024
@markoaamunkajo markoaamunkajo removed their assignment May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to deploy
Projects
None yet
Development

No branches or pull requests

4 participants