Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare sensors: fix battery voltage #428

Closed
markoaamunkajo opened this issue Aug 8, 2024 · 3 comments
Closed

Compare sensors: fix battery voltage #428

markoaamunkajo opened this issue Aug 8, 2024 · 3 comments
Labels
ready to deploy

Comments

@markoaamunkajo
Copy link
Collaborator

Describe:

These are some pretty big batteries!
Let's fix the formatting same as on sensor page, please check all of them are matching on Compare page

Image
@markoaamunkajo markoaamunkajo added the bug Something isn't working label Aug 8, 2024
@io53
Copy link
Collaborator

io53 commented Aug 8, 2024

Are you sure you didnt just accidentally put 1000 batteries in you tags? 😅

@markoaamunkajo
Copy link
Collaborator Author

Mine is the new high voltage version! 😆

io53 pushed a commit that referenced this issue Aug 13, 2024
fixed unit issue in compare view #428
00c491a
@io53 io53 assigned markoaamunkajo and unassigned io53 Aug 13, 2024
@markoaamunkajo
Copy link
Collaborator Author

markoaamunkajo commented Aug 14, 2024 •
edited
Loading

QA passed

@markoaamunkajo markoaamunkajo added ready to deploy and removed bug Something isn't working labels Aug 14, 2024
@io53 io53 assigned markoaamunkajo and unassigned io53 Aug 21, 2024
@markoaamunkajo markoaamunkajo removed their assignment Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready to deploy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@io53 @markoaamunkajo