Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paoloantinori
Copy link

Hi please consider the following aspects and test it a little before considering merging:

  • I'm not a .js expert and in particular I just wanted it to work for this first version!
  • I had to remove recently introduce support for q to quit the app, otherwise it was interfering with filtering, so technically it rolls back added 'q' to quit prompt #5
  • I have bound filtering to / and ESC exits bc completely
  • I have forked Inquirer.js https://github.com/paoloantinori/Inquirer.js/tree/filter , because my 'filter' Prompt class is neither generic enough to expect being added upstream nor has the quality the original project has. For this reason I'm pointing to my branch on github in packages.json. If you have other strategies regarding where to put this code, I'm happy to hear your suggestions.
  • If you think we might start bringing the feature to a separate branch instead of going directly to master, I can re-open the PR

Fixes #4

@ruyadorno
Copy link
Owner

Hi @paoloantinori, thanks for all the effort, I took a quick look at the code and it's looking great.

I think it would be much better if we can extract your filter prompt into an isolated module/plugin that we can use with Inquirer.js instead - That can be amazingly useful for other projects, if we get it right even Yeoman Generators can make use of it 😄

I'll have to find some free time to test everything, see how the plugin is working with the filtering and also to validate the possibility of extracting your filter code from the Inquirer.js fork.

I'll keep you posted.

@ruyadorno
Copy link
Owner

@paoloantinori Just saw this Inquirer plugin (unfortunately his implementation seems to only work for file paths) in my twitter feed and remembered about your PR, maybe it can be a good reference on how to implement your solution as a separated plugin as I have suggested before 😊

https://github.com/Nytramr/mr-inquirer

@paoloantinori
Copy link
Author

I'll have a look! I won't be quick, but I am planning to spend some time
with node!

On Tue, Jul 28, 2015 at 4:50 PM, Ruy Adorno notifications@github.com
wrote:

@paoloantinori https://github.com/paoloantinori Just saw this Inquirer
plugin (unfortunately his implementation seems to only work for file paths)
in my twitter feed and remembered about your PR, maybe it can be a good
reference on how to implement your solution as a separated plugin as I have
suggested before [image: 😊]

https://github.com/Nytramr/mr-inquirer


Reply to this email directly or view it on GitHub
#6 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants