This repository has been archived by the owner on Apr 5, 2018. It is now read-only.
Added possibility to specify End of Line character in output #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the issue?
Currently node-pygmentize-bundled adds OS-specific line endings to output, even if input source code has diffrent line endings. I've faced this issue while working with grunt plugin which is using this project.
Since Windows by default uses
\r\n
as its EOL, it started to result with files having both\n
and\r\n
mixed in.I've started to dig it a little bit, and tested Pygments itself, but it was managing EOLs as expected.
Because of this issue node-pygmentize-bundled tests were failing too at Win.
Design concept:
I didn't change the defalut behaviour, lines will be changes only when the
options.eol
property will be set - this way it will keep backward compatibility.I've added a note to options list in README.md.
What I've done here?
index.js modifications:
Changes went to both
fromString
andfromStream
functions.osEolRegExp
variable, which will store a RegExp for OS EOL.options
. Options allows us to check desired EOL markers.options.eol
was explicitly specified:test.js modifications:
options.eol = "\n"
in each TC, since this is the case that we want to work with.Extra thoughts
I didn't test this solution on Mac, so it might be a good idea to check it there.