make @types/readable-stream a standard dependency #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin types reference
@types/readable-stream
but don't include it as a dependency (it's currently in devDependencies) meaning consumers of this package must explicitly include@types/readable-stream
in their own dependencies for types to resolve properly. Without this fix,tsc
gives errors like the following:Moving type dependencies into
dependencies
matches the guidance in Typescript docs https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#dependencies