Skip to content

Commit

Permalink
test: mark test-cluster-bind-privileged-port flaky on arm
Browse files Browse the repository at this point in the history
Per rvagg:
```
Persistent failure, even after restarts of the whole cluster. nodejs#36478 was
merged into this test yesterday but the parent commit still has the
failures.

What has changed is the Docker version. They all got an upgrade to
5:20.10.2~3-0~raspbian-buster and this is all running inside containers.
It's going to be the newest version of Docker running in our CI and I
wonder whether we're going to see similar failures when we upgrade other
hosts or if this is going to be restricted to ARM.

Other than that, I'm not sure what this could be. It seems like a
straightforward test that shouldn't fail, maybe Docker has introduced
something new for unprivileged port binding inside containers?
```

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#36850
Refs: nodejs#36847
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
  • Loading branch information
jasnell committed Jan 8, 2021
1 parent db12ece commit a45a404
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ test-async-hooks-http-parser-destroy: PASS,FLAKY
# https://github.com/nodejs/node/pull/31178
test-crypto-dh-stateless: SKIP
test-crypto-keygen: SKIP
# https://github.com/nodejs/node/issues/36847
test-cluster-bind-privileged-port: PASS,FLAKY
test-cluster-shared-handle-bind-privileged-port: PASS,FLAKY

[$system==solaris] # Also applies to SmartOS

Expand Down

0 comments on commit a45a404

Please sign in to comment.