Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the tutorials to match the changed code #2

Open
rvodden opened this issue Sep 19, 2020 · 6 comments
Open

Rewrite the tutorials to match the changed code #2

rvodden opened this issue Sep 19, 2020 · 6 comments
Labels
documentation Improvements or additions to documentation
Milestone
0.1.0

Comments

@rvodden
Copy link
Owner

rvodden commented Sep 19, 2020

No description provided.

@rvodden rvodden added the documentation Improvements or additions to documentation label Sep 20, 2020
@rvodden rvodden added this to the 0.1.0 milestone Sep 20, 2020
@firasm
Copy link

firasm commented Oct 15, 2020

Just came across this and I'd love to help get the documentation right!

@rvodden
Copy link
Owner Author

rvodden commented Oct 24, 2020 •
edited
Loading

@firasm that would be amazing, and sorry for the slow reply! Have a look at the bugfix/#2 branch and see what you make of it.

rvodden added a commit that referenced this issue Oct 29, 2020
@rvodden @dependabot-preview
Bugfix/#2 (#21)
158135f 
* Fix finite differences

* Fixed comprehensive rectangles

* Fixed flow_over_gaussian

* Painted the examples black

* Set up ReadTheDocs

* Added contents pages to readthedocs

* Fixed wheel_on_inclined_plane

* Fixed tutorial vehical picture

* Painted everything black

* Painted all the thing blacker

* isorted everything

* painted the docs black

* Migrated unit tests to hypothesis

* Bump mypy from 0.770 to 0.790 (#7)

* Bump mypy from 0.770 to 0.790

Bumps [mypy](https://github.com/python/mypy) from 0.770 to 0.790.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.770...v0.790)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated poetry.lock to reflect new dependency versions

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>

* Bump hypothesis from 5.38.0 to 5.38.1 (#16)

* Bump hypothesis from 5.38.0 to 5.38.1

Bumps [hypothesis](https://github.com/HypothesisWorks/hypothesis) from 5.38.0 to 5.38.1.
- [Release notes](https://github.com/HypothesisWorks/hypothesis/releases)
- [Commits](HypothesisWorks/hypothesis@hypothesis-python-5.38.0...hypothesis-python-5.38.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated poetry.lock to reflect new dependency versions

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>

* Bump pytest from 5.4.3 to 6.1.1 (#10)

* Bump pytest from 5.4.3 to 6.1.1

Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.4.3 to 6.1.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@5.4.3...6.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated poetry.lock to reflect new dependency versions

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>

* Set up ReadTheDocs

* Got inclined wheel working

* Fixed badges

* Fixed badges

* Bump zest-releaser from 6.22.0 to 6.22.1 (#5)

* Bump zest-releaser from 6.22.0 to 6.22.1

Bumps [zest-releaser](https://zestreleaser.readthedocs.io) from 6.22.0 to 6.22.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Fixed circle to build dependabot prs

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Richard Vodden <richard.vodden@babylonhealth.com>

* Set up ReadTheDocs

* Painted all the thing blacker

* Fixed badges on README.md

* Synced deps with master

* Fixed comprehensive rectangles

* Fixed flow_over_gaussian

* Painted the examples black

* Added contents pages to readthedocs

* Fixed wheel_on_inclined_plane

* Fixed badges

* Fixed badges

* Created tutorial schedule

* Added some documentation

* Removed tests from codeclimate commentary

* Removed tests from codeclimate commentary

* Updated poetry.lock

* Fixed the cognitive complexity of line.__call__()

* Made composition naming consistent

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>
rvodden pushed a commit that referenced this issue Oct 30, 2020
Merge branch 'master' into bugfix/#2
d454228
rvodden added a commit that referenced this issue Nov 1, 2020
@rvodden @dependabot-preview
Bugfix/#2 (#26)
806ad8a 
* Fix finite differences

* Fixed comprehensive rectangles

* Fixed flow_over_gaussian

* Painted the examples black

* Set up ReadTheDocs

* Added contents pages to readthedocs

* Fixed wheel_on_inclined_plane

* Fixed tutorial vehical picture

* Painted everything black

* Painted all the thing blacker

* isorted everything

* painted the docs black

* Migrated unit tests to hypothesis

* Bump mypy from 0.770 to 0.790 (#7)

* Bump mypy from 0.770 to 0.790

Bumps [mypy](https://github.com/python/mypy) from 0.770 to 0.790.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.770...v0.790)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated poetry.lock to reflect new dependency versions

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>

* Bump hypothesis from 5.38.0 to 5.38.1 (#16)

* Bump hypothesis from 5.38.0 to 5.38.1

Bumps [hypothesis](https://github.com/HypothesisWorks/hypothesis) from 5.38.0 to 5.38.1.
- [Release notes](https://github.com/HypothesisWorks/hypothesis/releases)
- [Commits](HypothesisWorks/hypothesis@hypothesis-python-5.38.0...hypothesis-python-5.38.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated poetry.lock to reflect new dependency versions

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>

* Bump pytest from 5.4.3 to 6.1.1 (#10)

* Bump pytest from 5.4.3 to 6.1.1

Bumps [pytest](https://github.com/pytest-dev/pytest) from 5.4.3 to 6.1.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@5.4.3...6.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Updated poetry.lock to reflect new dependency versions

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>

* Set up ReadTheDocs

* Got inclined wheel working

* Fixed badges

* Fixed badges

* Bump zest-releaser from 6.22.0 to 6.22.1 (#5)

* Bump zest-releaser from 6.22.0 to 6.22.1

Bumps [zest-releaser](https://zestreleaser.readthedocs.io) from 6.22.0 to 6.22.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Fixed circle to build dependabot prs

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Richard Vodden <richard.vodden@babylonhealth.com>

* Set up ReadTheDocs

* Painted all the thing blacker

* Fixed badges on README.md

* Synced deps with master

* Fixed comprehensive rectangles

* Fixed flow_over_gaussian

* Painted the examples black

* Added contents pages to readthedocs

* Fixed wheel_on_inclined_plane

* Fixed badges

* Fixed badges

* Created tutorial schedule

* Added some documentation

* Removed tests from codeclimate commentary

* Removed tests from codeclimate commentary

* Updated poetry.lock

* Fixed the cognitive complexity of line.__call__()

* Made composition naming consistent

* Introduced the Angle object

* Fixed tests

* Told pytest to test docstrings (and fixed them :) )

* Factored the drawing logic out to backend

* Fixed erroneous imports

* Fixed simple circle.py

* Fixed layered_medium_3xi.py

* Fixed vehicle_dim.py

* Fixed vehicle

* Fixed pendulum1.py

* Fixed poetry lock file

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: CirleCI Automation <automation@circleci.com>
@firasm
Copy link

firasm commented May 3, 2021

Hi @rvodden , my turn to apologize for the delayed reply. It was a long and busy term! I just finished teaching my courses for the term and am now directing my efforts to creating an open problem bank. I was hoping to evaluate whether PySketcher could be a useful component in creating randomized images that go along with my problems.

I see that the bugfix/#2 branch is now merged into master. I'm going to try my hand at reproducing a couple of basic examples to see if things work.

I have some people-power available in the form of some students that might be able to help with some documentation and clean-up tasks as well.

Thanks for working on this and picking up maintenance of the package!

@rvodden
Copy link
Owner Author

rvodden commented May 22, 2021

Randomized images is a very interesting idea. If you get it to work it would be great to see. Maybe we could create a contrib section in the repo, or something in the documentation, so others with similar ideas could benefit?

@hdeavila1992
Copy link

Hi @rvodden , my turn to apologize for the delayed reply. It was a long and busy term! I just finished teaching my courses for the term and am now directing my efforts to creating an open problem bank. I was hoping to evaluate whether PySketcher could be a useful component in creating randomized images that go along with my problems.

I see that the bugfix/#2 branch is now merged into master. I'm going to try my hand at reproducing a couple of basic examples to see if things work.

I have some people-power available in the form of some students that might be able to help with some documentation and clean-up tasks as well.

Thanks for working on this and picking up maintenance of the package!

¿Did you manage to create randomize problems ?

@firasm
Copy link

firasm commented Nov 20, 2023

We tried to do this but unfortunately the generator was a bit cumbersome to generalize so we manually created images with symbols in place of numbers and randomized the values in the question text.

Thanks for following up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@firasm @rvodden @hdeavila1992