-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: protoc-gen-scala support #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the status here? Is the arm64
not supported yet? If so, how about we file an issue about it and fix up in a follow-up?
Not ready yet, I need to block out some time for more testing and to get the version strings compatible with Renovate here. I'll test |
I've made progress on this and understand the build process (and the errors I was seeing) much better now. I expect we will be able to complete this PR using a different build method when this fix is merged, it doesn't look like it will take too long. |
@rvolosatovs this is finally ready. The builder will not be versioned by Renovate since Scala sbt downloads different compilers as necessary. I ended up getting help from the ScalaPB maintainers and using the original build approach, will ask for help sooner next time 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but could you drop the merge commit?
Simply squashing all the commits into one based on top of latest main
would be fine as well IMO (although as a nitpick it would probably be nicer to have a separate commit for reordering of the README list first)
Thanks for the clear instructions, I installed GitLens and finally think I did it correctly! 🎉 |
Great job, thanks! |
Initial implementation of
protoc-gen-scala
. Still need to figure out what Java dependencies are required to run this in the target stage, particularly onarm64
.