This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Makefile, front: Add js test target #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafonins
force-pushed
the
fix/makefile-js-test
branch
from
02b8d94
to
698bff2
Compare
|
Why not add the --coverage flag only in the Makefile? This disables the imo useful watch mode in favor of showing coverage, which can be shown anyway by adding the --coverage flag. Removing flags is much harder. |
bafonins
force-pushed
the
fix/makefile-js-test
branch
from
698bff2
to
6d3fb0d
Compare
rvolosatovs
approved these changes
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add js target to the Makefile.
Disable watch mode when using jest, see facebook/create-react-app#1207