extend event class & add event tile height #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jnelle <jimmy@nelle.sh>
* also formaatted the file * I had to add the height, because I faced a renderoverflow Signed-off-by: jnelle <jimmy@nelle.sh>
rwbr
requested changes
Sep 18, 2022
|
Introducing the height property for the event tiles is a good idea. |
|
Hi, I changed it and gonna open a new one when this pr gets merged |
|
ping |
|
Hi, is it possible to merge this now? |
|
Sure, sorry for the delay |
rwbr
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Includes PR #42 extend event class & add event tile height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, thanks for maintaining this package!
I faced an issue with the event tile (check screenshot), that's why I added the height attribute to the widget.
Also in my case it was important save additional informations in an event object, that's why I added an attribute to the event class.