update confusing usage example in readme #38
Conversation
README.md
Outdated
| {{#each this.availableCountries as |country|}} | ||
| {{#s.option value=country}}{{country.name}}{{/s.option}} | ||
| {{#option value=country}}{{country.name}}{{/s.option}} |
There was a problem hiding this comment.
You can't call a non-angle bracket component without a dash, that is why the API is different. To make it similar you'd use {{#component option value=country}}.
There was a problem hiding this comment.
Of course. Missed that one. So maybe it should be done the other way round? Assuming it returns a hash and updating the angle bracket syntax accordingly?
There was a problem hiding this comment.
Or is it attended to show this difference? At least without an explanation that was very confusing to me.
There was a problem hiding this comment.
The other way around makes sense to me.
There was a problem hiding this comment.
Updated the PR accordingly.
jelhan
force-pushed
the
fix-confusing-usage-example
branch
from
72f5227 to
86ec2f0
Compare
|
Please note, that |
Example assumed that component yields a hash before but a component after changing syntax. Since angle bracket invocation does not affect yielded value it should be the same before and after. [ci skip]
jelhan
force-pushed
the
fix-confusing-usage-example
branch
from
86ec2f0 to
5916976
Compare
Example assumed that component yields a hash before but a component after changing syntax. Since angle bracket invocation does not affect yielded value it should be the same before and after.
It's the same in RFC. Not quite sure if the RFC should be changed also even so it's already merged.