PostprocessingDataset: add composition function
#1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoLegends
force-pushed
the
moritz-pp-composition-function
branch
2 times, most recently
from
03d0186 to
e224b4d
Compare
NeoLegends
force-pushed
the
moritz-pp-composition-function
branch
from
e224b4d to
27437fe
Compare
michelwi
reviewed
Aug 29, 2024
albertz
reviewed
Aug 29, 2024
Co-authored-by: Albert Zeyer <albzey@gmail.com>
albertz
reviewed
Aug 29, 2024
albertz
reviewed
Aug 29, 2024
albertz
reviewed
Aug 29, 2024
albertz
reviewed
Aug 29, 2024
michelwi
reviewed
Aug 29, 2024
Co-authored-by: michelwi <michelwi@users.noreply.github.com>
albertz
reviewed
Aug 29, 2024
|
What is the syntax for the comments that turn off the linter for a specific line? |
Why? Where do you want to turn it off? I'm pretty sure there are no valid cases here to turn it off. All warnings given by the linter (see failing test) are totally correct, and you should fix the code instead. |
albertz
reviewed
Aug 29, 2024
albertz
reviewed
Aug 29, 2024
Co-authored-by: Albert Zeyer <albzey@gmail.com>
michelwi
approved these changes
Aug 30, 2024
albertz
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a common pattern much easier.
@albertz Any comments on the added docs?