Clearing timeout on unmount #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
========================================
- Coverage 100% 91.3% -8.7%
========================================
Files 1 1
Lines 20 23 +3
Branches 2 2
========================================
+ Hits 20 21 +1
- Misses 0 2 +2
Continue to review full report at Codecov.
|
rwu823
added a commit
that referenced
this pull request
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a warning that happens when calling setState on an unmounted component. The cause is setTimeout will still run after the component was unmounted.
Ran into this when working on a wizard where you got onto the next step before the ripple can finish animating.