Server not serving assets as the current rack app does not match the Rails.application

[rahult]

Removed an explicit check to compare a Rack app with Rails.application

I was having issue with using this gem with any application which has a NewRelic RPM gem

As NewRelic gem was overwriting the structure of the current Rack app in such a way that the current Rails was stored under app.target instead of app.

I think we can get away with just checking if we have a Rails.application defined as that give us enough surety that their is a Rails Application.

=> app
=> #<NewRelic::Agent::Instrumentation::MiddlewareProxy:0x007f8684fd9988
 @category=:rack,
 @is_app=true,
 @target=
  #<Gymy::Application:0x007f8685fceca8
   @_all_autoload_paths=
    ["/Users/rahult/Development/katalyst/rails/koi/gymy/app/assets", ...],
   @_all_load_paths=
    ["/Users/rahult/Development/katalyst/rails/koi/gymy/lib", ...],
   @app=
    #<NewRelic::Agent::Instrumentation::MiddlewareProxy:0x007f8685fa4368

instead of

=> app
=> #<Gymy::Application:0x007f8685fceca8
   @_all_autoload_paths=
    ["/Users/rahult/Development/katalyst/rails/koi/gymy/app/assets", ...],
   @_all_load_paths=
    ["/Users/rahult/Development/katalyst/rails/koi/gymy/lib", ...],
   @app=
    #<NewRelic::Agent::Instrumentation::MiddlewareProxy:0x007f8685fa4368

[rondale-sc]

I suspect this is okay. /cc @rwz

[rwz]

That rack app hack should only happen in development. So my question would be why do you even have newrelic in development environment?

I don't feel it's safe to assume that any rack server starting in dev environment is a rails app. I believe this patch will break more code than it'll fix.

[rahult]

We generally use NewRelic in development to do some basic performance analysis. I can get away with not using it in development.

However I still think we should put a warning or an error message if EmberCLI.run! is not executed due to something like this. As otherwise it is hard to debug.

[rwz]

Please check the new version I've just released. This problem should be fixed :)

[rahult]

Awesome dude, it is fixed now, thank you 😄