Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-cli-rails does not interact well with ember-cli addons that load external javascript #220

Closed
jeffreybiles opened this issue Oct 17, 2015 · 5 comments
Closed

ember-cli-rails does not interact well with ember-cli addons that load external javascript #220

jeffreybiles opened this issue Oct 17, 2015 · 5 comments

Comments

@jeffreybiles
Copy link

I've been trying to use ember-cli-stripe and/or ember-stripe-service, and they both are failing when using ember-cli-rails. They both rely on loading an external javascript library from Stripe, and both are failing for the reason that the global loaded by the library (Stripe or StripeCheckout) is not defined. When I run the ember-cli app on its own the problem disappears, leading me to believe that the problem is with ember-cli-rails.

Thanks for making this gem! Wish I could offer a PR to go with the issue, but I'm pretty stumped.
@seanpdoyle
Copy link
Contributor

@jeffreybiles thanks for bringing this to our attention, it's on our radar and we're looking into it.

seanpdoyle added a commit that referenced this issue Oct 24, 2015
@seanpdoyle
Expose EmberCLI generated index.html
1017748 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
@seanpdoyle seanpdoyle mentioned this issue Oct 24, 2015
Merged
seanpdoyle added a commit that referenced this issue Oct 24, 2015
@seanpdoyle
Expose EmberCLI generated index.html
9599942 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 24, 2015
@seanpdoyle
Expose EmberCLI generated index.html
2dd32db 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
@seanpdoyle
Copy link
Contributor

@jeffreybiles initial implementation in #224

seanpdoyle added a commit that referenced this issue Oct 24, 2015
@seanpdoyle
Expose EmberCLI generated index.html
da22f9f 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 24, 2015
@seanpdoyle
Expose EmberCLI generated index.html
ef2a376 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 24, 2015
@seanpdoyle
Expose EmberCLI generated index.html
71919c8 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 27, 2015
@seanpdoyle
Expose EmberCLI generated index.html
4fd9341 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 28, 2015
@seanpdoyle
Expose EmberCLI generated index.html
6ab3124 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 28, 2015
@seanpdoyle
Expose EmberCLI generated index.html
91ef885 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
d5d65cd 
Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
769bf25 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmebrCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
89fb3fd 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
2188836 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
383b85c 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
c4b8ffa 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
dbb9508 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
3d2401d 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
0574186 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
3484d27 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
9d2ec11 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
seanpdoyle added a commit that referenced this issue Oct 29, 2015
@seanpdoyle
Expose EmberCLI generated index.html
2dda73a 
Depends on [rondale-sc/ember-cli-rails-addon#][#15].

Closes [#220].

Exposes new public methods for `EmberCLI::App`:

* `#index_html` - return the EmberCLI generated `index.html` string
* `#application_assets` - return the EmberCLI exposes app assets
* `#vendor_assets` - return the EmberCLI exposes vendor assets

Exposes new Rails helper:

* `include_ember_index_html` - Renders the `index.html` inline.
  Replaces EmberCLI asset paths with Sprockets asset paths

[#15]: rondale-sc/ember-cli-rails-addon#15
[#220]: #220
@seanpdoyle seanpdoyle mentioned this issue Oct 29, 2015
Closed
@seanpdoyle
Copy link
Contributor

@jeffreybiles could you give master a shot?

#224 should address your issues.

Also, it might be worth checking out #228

@seanpdoyle
Copy link
Contributor

Give https://github.com/thoughtbot/ember-cli-rails/releases/tag/v0.4.0 a shot!

@jeffreybiles
Copy link
Author

Thanks, this will be very useful for next iteration of the payment system. If I had planned ahead better, I would have saved the spike that was using stripe within Ember.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffreybiles @seanpdoyle