[In progress] Modernize Build tooling, optimize code size

[onigoetz]

Hello,
as discussed in the Globalize repository, this pull request will make a version that is optimizable by build tools like webpack.

But there is a lot of work required to get there due to the tools used currently
I open this pull request early so that you can see the progress and give your feedback if you're ok with the direction it's taking

• Convert Code to use require() from nodejs
• Remove Bower, do everything through npm
• Use rollup or webpack to build bundles
• Convert Code to ES 6 imports, gives better results when optimizing with Webpack
• Change output so we don't need to add ".default" on import without babel
• Use babel in compilation to wrap validate*( with conditions to remove them in production builds
• Provide a "source" build for webpack
• Use eslint + prettier instead of jshint

[onigoetz]

Hi @rxaviers,

I finished the initial implementation of the changes.

You can start reviewing if you feel like it. I still need to add a few benchmarks on what you can expect for the final size with all the "validate" calls removed in production and do some tests to make sure that everything works as it did before.

I recommend you look at the commits separately, I tried to make them in the right order and well separated, otherwise, looking at all the changes at once might give you a headache :)

I also recommend checking the box "Hide whitespace changes" to have less false positives of line changes.

[rxaviers]

Awesome! Thank you for your contribution. One highlevel comment for now: Mocha doesn't need a browser to run either. Can we do the analogous test changes you did but keeping mocha? Thanks

[onigoetz]

Oh, I was sure of the contrary. my mistake :)

I will revert that part then. I have to admit I'm more familiar with Jest, but I'll figure it out :)

[rxaviers]

Also feel free to get rid of grunt and instead use npm scripts directly.

[rxaviers]

About mocha, follow an example https://github.com/rxaviers/async-pool/blob/master/package.json#L8 (also check https://github.com/rxaviers/async-pool/blob/master/test/mocha.opts).

[onigoetz]

Good to know for Grunt, but there is no cli for grunt-dco / dco . Do you want to keep that plugin ?

Thanks for the links for Mocha

[rxaviers]

Good point! We can leave only that in grunt for now until a CLI is made available for it, which shouldn't be hard to create (that hypothetical module could use https://github.com/scottgonzalez/dco)

[onigoetz]

sure, I already checked how hard it would be to create that, but I wanted to make sure that you still want it first :)

[rxaviers]

Thanks for checking!

[onigoetz]

Oh and I wanted to ask, do you wish to keep jshint or to use eslint ?

[rxaviers]

Let's go with eslint + prettier (we could use https://github.com/rxaviers/async-pool/blob/master/package.json settings as baseline for that too)

[onigoetz]

aaand, mocha and eslint it is :)

[onigoetz]

I also made a small script to replace grunt-dco and removed grunt

[onigoetz]

"yarn build" or "npm run build" builds everything now

[onigoetz]

I made some tests on the size of the library

File	0.5.0 (min)	Current, build	Current, through webpack
cldr.js	4586 B	5659 B ( +1073 )	1055 B ( -3531 )
cldr/event.js	3881 B	5435 B ( +1554 )	6682 B ( +2801 )
cldr/supplemental.js	1175 B	2325 B ( +1150 )	3865 B ( +2690 )
cldr/unresolved.js	1141 B	2737 B ( +1596 )	3931 B ( +2790 )
All	10783 B	16156 B ( +5373 )	9525 B ( -1258 )

It seems the UMD build is bigger, but the global size of the build with webpack is smaller.

[rxaviers]

What you have done here is already a big improvement and therefore I am merging it. I still want to do additional things with respect to the build and modules. Will post details in an upcoming PR.

[rxaviers]

Follow up #66