Add optional tmpdirBase attribute

[diligiant]

Facebook createreactapp ModuleScopePlugin enforces all files to be children of the source directory.

A simple

tmpdirBase: paths.appSrc,

addition to the plugin configuration will ensure conformance to this rule.

create-react-app issue #2404 needs also to be fixed (PR opened) as it prevents dot directories to pass ModuleScopePlugin gatekeeper.

[rxaviers]

Let's use path.join instead of +.

[rxaviers]

Please, can you update documentation (i.e., README.md) with this additional attribute.

[rxaviers]

Can you explain the motivation please, it's not immediately clear to me why these temporary files need to be inside your source path.

[diligiant]

Where should I explain the motivation? Without this change, create-react-app ModuleScopePlugin raises

Module not found: You attempted to import /path_root_here/website/.tmp-globalize-webpack/dev-i18n-data.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported. You can either move it inside src/, or add a symlink to it from project's node_modules/.

As you know i18n-data.js and other files are created by the plugin (dev mode) and the globalize-compiler respectively (production mode).

[rxaviers]

Ok @diligiant thanks for the clarification. I think the above comment is enough for my understanding. For the documentation, I think it's sufficient to simply include tmpdirBase and explain what it is and mention the default is .tmp.

It's also important to add tests to ensure the different values provided to tmpdirBase work as expected.

Thanks so far.

[diligiant]

Will add tests later today

[rxaviers]

Excellent, ok.

[diligiant]

@rxaviers hope the added test suits you. You'll see that I tried to be creative with the indentation of the GlobalizePlugin object ;)
And I signed-off the last commit.

my create-react-app PR has been merged so this PR might be useful after all!