Add the validation for runs

rxin · Jul 1, 2015 · 444c289 · 444c289
1 parent e41989c
commit 444c289
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala b/mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
@@ -51,7 +51,8 @@ private[clustering] trait KMeansParams
    * return the best clustering found over any run. Default: 1.
    * @group param
    */
-  val runs = new Param[Int](this, "runs", "number of runs of the algorithm to execute in parallel")
+  val runs = new Param[Int](this, "runs", "number of runs of the algorithm to execute in parallel",
+    (value: Int) => value >= 1)
 
   /** @group getParam */
   def getRuns: Int = $(runs)

diff --git a/mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala
@@ -68,6 +68,9 @@ class KMeansSuite extends SparkFunSuite with MLlibTestSparkContext {
     intercept[IllegalArgumentException] {
       new KMeans().setInitializationSteps(0)
     }
+    intercept[IllegalArgumentException] {
+      new KMeans().setRuns(0)
+    }
   }
 
   test("fit & transform") {