forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-5441][pyspark] Make SerDeUtil PairRDD to Python conversions mo…
…re robust SerDeUtil.pairRDDToPython and SerDeUtil.pythonToPairRDD now both support empty RDDs by checking the result of take(1) instead of calling first which throws an exception. Author: Michael Nazario <mnazario@palantir.com> Closes apache#4236 from mnazario/feature/empty-first and squashes the following commits: a531c0c [Michael Nazario] Added regression tests for SPARK-5441 e3b2fb6 [Michael Nazario] Added acceptance of the empty case
- Loading branch information
Showing
2 changed files
with
47 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
core/src/test/scala/org/apache/spark/api/python/SerDeUtilSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.api.python | ||
|
||
import org.scalatest.FunSuite | ||
|
||
import org.apache.spark.SharedSparkContext | ||
|
||
class SerDeUtilSuite extends FunSuite with SharedSparkContext { | ||
|
||
test("Converting an empty pair RDD to python does not throw an exception (SPARK-5441)") { | ||
val emptyRdd = sc.makeRDD(Seq[(Any, Any)]()) | ||
SerDeUtil.pairRDDToPython(emptyRdd, 10) | ||
} | ||
|
||
test("Converting an empty python RDD to pair RDD does not throw an exception (SPARK-5441)") { | ||
val emptyRdd = sc.makeRDD(Seq[(Any, Any)]()) | ||
val javaRdd = emptyRdd.toJavaRDD() | ||
val pythonRdd = SerDeUtil.javaToPython(javaRdd) | ||
SerDeUtil.pythonToPairRDD(pythonRdd, false) | ||
} | ||
} | ||
|