fix(fileserver): wrong url href of displayed files (denoland/std#426)

Original: denoland/std@be6cd35
ry · May 22, 2019 · e2debab · e2debab
1 parent de713ea
commit e2debab
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/http/file_server.ts b/http/file_server.ts
@@ -162,7 +162,7 @@ async function serveDir(
     listEntry.push(
       createDirEntryDisplay(
         info.name,
-        fn,
+        fn.replace(currentDir, ""),
         info.isFile() ? info.len : null,
         mode,
         info.isDirectory()

diff --git a/http/file_server_test.ts b/http/file_server_test.ts
@@ -56,6 +56,18 @@ test(async function serveDirectory(): Promise<void> {
     assert(res.headers.has("access-control-allow-headers"));
     const page = await res.text();
     assert(page.includes("azure-pipelines.yml"));
+
+    // `Deno.FileInfo` is not completely compatible with Windows yet
+    // TODO: `mode` should work correctly in the future. Correct this test case accordingly.
+    Deno.platform.os !== "win" &&
+      assert(/<td class="mode">\([a-zA-Z-]{10}\)<\/td>/.test(page));
+    Deno.platform.os === "win" &&
+      assert(/<td class="mode">\(unknown mode\)<\/td>/.test(page));
+    assert(
+      page.includes(
+        `<td><a href="/azure-pipelines.yml">azure-pipelines.yml</a></td>`
+      )
+    );
   } finally {
     killFileServer();
   }