Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statistics): add Statistical Classifications feature and refactor imports with barrel files #65

Merged
merged 62 commits into from
Jun 1, 2024

Conversation

ryanaidilp
Copy link
Owner

@ryanaidilp ryanaidilp commented Jun 1, 2024

Status

READY

Description

I propose enhancing the FLUTTER STADATA SDK with a new feature that allows users to fetch Statistical Classifications (KBLI & KBKI) data from the BPS (Badan Pusat Statistik) API. This enhancement will empower developers using the SDK to access and incorporate statistical classification data into their Flutter applications seamlessly.

Key Changes:

  • Implemented a new function/method in the SDK to retrieve Statistical Classifications (KBLI & KBKI) data from the BPS API.
  • Developed comprehensive unit tests for the newly added function/method to ensure its accuracy and reliability.
  • Maintained a test coverage of no less than 90% for the newly introduced feature.
  • Updated the SDK's documentation to include instructions on how to use the new feature, complete with illustrative examples.
  • Refactored the code to use barrel files for efficient file import.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Related Issues

I open a pull request for these issues: #24, #64

ryanaidilp added 30 commits May 4, 2024 11:02
@ryanaidilp ryanaidilp added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file refactor Improvements or changes to code labels Jun 1, 2024
@ryanaidilp ryanaidilp self-assigned this Jun 1, 2024
@ryanaidilp ryanaidilp changed the base branch from main to develop June 1, 2024 03:40
@ryanaidilp ryanaidilp changed the title Feature/statistical classification feat(statistical_classification): add KBLI & KBKI, bug fix pagination, and code refactor Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 85.77406% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 96.48%. Comparing base (ee80219) to head (c7e3b8f).

Files Patch % Lines
...on/data/models/statistic_classification_model.dart 59.32% 24 Missing ⚠️
...ication/data/models/classification_item_model.dart 60.00% 4 Missing ⚠️
...ata_flutter_sdk/lib/src/core/base/base_entity.dart 62.50% 3 Missing ⚠️
...s/statistic_classification_remote_data_source.dart 94.59% 2 Missing ⚠️
...a_flutter_sdk/lib/src/core/helper/date_helper.dart 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #65      +/-   ##
===========================================
+ Coverage    96.03%   96.48%   +0.45%     
===========================================
  Files           88      100      +12     
  Lines         1310     1535     +225     
===========================================
+ Hits          1258     1481     +223     
- Misses          52       54       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanaidilp ryanaidilp changed the title feat(statistical_classification): add KBLI & KBKI, bug fix pagination, and code refactor feat(statistics): add Statistical Classifications feature and refactor imports with barrel files Jun 1, 2024
@ryanaidilp ryanaidilp marked this pull request as ready for review June 1, 2024 05:35
@ryanaidilp ryanaidilp merged commit 4b31243 into develop Jun 1, 2024
6 of 7 checks passed
@ryanaidilp ryanaidilp deleted the feature/statistical-classification branch June 1, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request refactor Improvements or changes to code
Projects
None yet
1 participant