Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add colors to buttons #1

Merged
merged 42 commits into from
Feb 19, 2024
Merged

add colors to buttons #1

merged 42 commits into from
Feb 19, 2024

Conversation

ryanatkn
Copy link
Owner

@ryanatkn ryanatkn commented Jan 15, 2024

This has some rough edges but I'm trying to keep the size manageable.

future:

  • thicker borders for selected states?
  • figure out text color variables
  • multiply/blend hover/active states (positioning ma
  • think about color shade variants (maybe color_a_1-9 etc?)
  • maybe both semantic_classes.css and utility_classes.css?
  • other elements like .chip_1 etc
  • figure out outline-offset in context of all elements (2px looks good for some things but will probably break a lot of expectations)
  • .deselectable needs a visual hover state not just cursor
  • bg/fg are inconsitent with their numbered versions, the former use tint, but we definitely don't want tint on the latter, blend modes would be correct

@ryanatkn ryanatkn marked this pull request as draft January 15, 2024 18:58
@ryanatkn ryanatkn marked this pull request as ready for review February 19, 2024 22:06
@ryanatkn ryanatkn merged commit e6a6f05 into main Feb 19, 2024
1 check passed
@ryanatkn ryanatkn deleted the colors branch February 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant